Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transverse pres gradient for spherical geometry. #296

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

zhichen3
Copy link
Collaborator

during calculation of the interface state, we should only apply pressure gradient to the momentum in the transverse direction since the normal direction momentum is already includes pressure term during reconstruction.

@zhichen3 zhichen3 marked this pull request as ready for review November 20, 2024 23:00
@zingale zingale merged commit 89a07d7 into python-hydro:main Dec 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants